-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Move the hir().krate()
method to a query and remove the Krate
dep node
#68889
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed in detailed but looks good to me in general. I left a couple of comments below.
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit a575495 with merge 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
☀️ Try build successful - checks-azure |
Queued 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb with parent 1f8df25, future comparison URL. |
Finished benchmarking try commit 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb, comparison URL. |
@bors r=eddyb |
📌 Commit a575495 has been approved by |
Move the `hir().krate()` method to a query and remove the `Krate` dep node r? @eddyb cc @michaelwoerister
Move the `hir().krate()` method to a query and remove the `Krate` dep node r? @eddyb cc @michaelwoerister
Rollup of 7 pull requests Successful merges: - #68164 (Selectively disable sanitizer instrumentation) - #68413 (Add GitHub issue templates) - #68889 (Move the `hir().krate()` method to a query and remove the `Krate` dep node) - #68909 (Respect --nocapture in panic=abort test mode) - #68910 (Add myself to .mailmap) - #68919 (Remove HashStable impl for ast::Lifetime) - #68928 (clean up E0276 explanation) Failed merges: r? @ghost
r? @eddyb cc @michaelwoerister