Skip to content

Move the hir().krate() method to a query and remove the Krate dep node #68889

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Feb 7, 2020

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 6, 2020

Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed in detailed but looks good to me in general. I left a couple of comments below.

@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 6, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Feb 6, 2020

⌛ Trying commit a575495 with merge 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb...

Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors
Copy link
Collaborator

bors commented Feb 6, 2020

☀️ Try build successful - checks-azure
Build commit: 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb (8cb5f974b0fce803a3fac318d3a6f0f58f91efbb)

@rust-timer
Copy link
Collaborator

Queued 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb with parent 1f8df25, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb, comparison URL.

@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 7, 2020

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Feb 7, 2020

📌 Commit a575495 has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 7, 2020
Move the `hir().krate()` method to a query and remove the `Krate` dep node

r? @eddyb cc @michaelwoerister
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 7, 2020
Move the `hir().krate()` method to a query and remove the `Krate` dep node

r? @eddyb cc @michaelwoerister
bors added a commit that referenced this pull request Feb 7, 2020
Rollup of 7 pull requests

Successful merges:

 - #68164 (Selectively disable sanitizer instrumentation)
 - #68413 (Add GitHub issue templates)
 - #68889 (Move the `hir().krate()` method to a query and remove the `Krate` dep node)
 - #68909 (Respect --nocapture in panic=abort test mode)
 - #68910 (Add myself to .mailmap)
 - #68919 (Remove HashStable impl for ast::Lifetime)
 - #68928 (clean up E0276 explanation)

Failed merges:

r? @ghost
@bors bors merged commit a575495 into rust-lang:master Feb 7, 2020
@Zoxc Zoxc deleted the hir-krate branch February 8, 2020 02:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants